Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: {@html} should handle null and undefined as empty string #13072

Closed
wants to merge 3 commits into from
Closed

feat: {@html} should handle null and undefined as empty string #13072

wants to merge 3 commits into from

Conversation

adiguba
Copy link
Contributor

@adiguba adiguba commented Aug 29, 2024

Fix #13069 {@html} should handle null and undefined as empty string

Note : I edited from github, so no test/lint :(

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d420920

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

thank you!

@Rich-Harris
Copy link
Member

uh wow looks like i broke a whole bunch of tests by tweaking the test logic. am about to get on a plane so if i can't fix it in the next five minutes, someone feel free to take over

@Rich-Harris
Copy link
Member

hmm. it seems that undefined and null are already rendered literally in Svelte 4 (that accounts for at least one of the test failures) so this is technically a breaking change — I think it's probably a sensible one (since it mirrors the behaviour of {nullish}) but would like a second opinion from maintainers!

trueadm
trueadm approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good and we have documented this breaking change in other areas so it makes sense here too.

@trueadm
Copy link
Contributor

trueadm commented Aug 31, 2024 •
edited
Loading

For some reason I don't have permissions to push to this PR. So I had to make a follow up PR #13092

@trueadm trueadm mentioned this pull request Aug 31, 2024
Merged
@adiguba adiguba closed this Sep 1, 2024
@adiguba adiguba deleted the fix-13069 branch September 1, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{@html} should handle null and undefined as empty string
3 participants
@adiguba @Rich-Harris @trueadm